<html>
<head><meta charset="utf-8"><title>Incr-patched tests · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html">Incr-patched tests</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="203531133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203531133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203531133">(Jul 10 2020 at 16:50)</a>:</h4>
<p>Hi. I asked this on <code>t-infra</code> before but got no answer. I'm guessing that's because maybe the people there don't know the details of the compiling time performance test suite.</p>
<p>Anywho, the question is: Why do some projects in <code>perf.rlo</code> not have <code>incr-patched</code> tests? I'm curious to know if those projects just aren't interesting to test in those circumstances, or if it was another reason like prioritization of resources on projects that showed more interesting performance nuances when patched.</p>
<p>Thanks! <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="203532503"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203532503" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203532503">(Jul 10 2020 at 17:03)</a>:</h4>
<p>it's just more effort to add those and the value isn't necessarily that great most of the time</p>



<a name="203536759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203536759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203536759">(Jul 10 2020 at 17:41)</a>:</h4>
<p>But would you add them if, say, someone came one day with a <code>patched</code> test for those projects?</p>



<a name="203536819"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203536819" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203536819">(Jul 10 2020 at 17:42)</a>:</h4>
<p>sure, there's not really much of a cost to having them</p>



<a name="203536860"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203536860" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203536860">(Jul 10 2020 at 17:42)</a>:</h4>
<p>Oh, excellent. That's what I wanted to know. Thanks, <span class="user-mention" data-user-id="119009">@eddyb</span> :)</p>



<a name="203536923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203536923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203536923">(Jul 10 2020 at 17:43)</a>:</h4>
<p>well there is some cost</p>



<a name="203536940"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203536940" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203536940">(Jul 10 2020 at 17:43)</a>:</h4>
<p>I wouldn't just go around adding patched tests for no reason</p>



<a name="203536961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203536961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203536961">(Jul 10 2020 at 17:43)</a>:</h4>
<p>it is, after all, time on our server</p>



<a name="203537011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537011">(Jul 10 2020 at 17:44)</a>:</h4>
<p>So it would be like a judgement call?</p>



<a name="203537070"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537070" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537070">(Jul 10 2020 at 17:44)</a>:</h4>
<p>Or what would it take for one to be worthy of being added?</p>



<a name="203537108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537108">(Jul 10 2020 at 17:44)</a>:</h4>
<p>Because I'm thinking of the converse question: what would it take to deprecate one incr-patched test from the suite?</p>



<a name="203537113"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537113" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537113">(Jul 10 2020 at 17:44)</a>:</h4>
<p>Seems like a question for <span class="user-mention" data-user-id="116083">@pnkfelix</span> / <a class="stream" data-stream-id="241847" href="/#narrow/stream/241847-t-compiler.2Fwg-incr-comp">#t-compiler/wg-incr-comp</a> in some sense</p>



<a name="203537118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537118">(Jul 10 2020 at 17:44)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I was thinking that they should be much faster than a full build of that crate</p>



<a name="203537151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537151">(Jul 10 2020 at 17:45)</a>:</h4>
<p>removing tests is a bad idea in practice</p>



<a name="203537153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537153">(Jul 10 2020 at 17:45)</a>:</h4>
<p><span class="user-mention silent" data-user-id="119009">eddyb</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Incr-patched.20tests/near/203537118">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> I was thinking that they should be much faster than a full build of that crate</p>
</blockquote>
<p>Ohh, good point</p>



<a name="203537157"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537157" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537157">(Jul 10 2020 at 17:45)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span> depends on how good incremental is :)</p>
<p>IIRC for some crates the patched runs are like 70% of the build time</p>



<a name="203537174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537174">(Jul 10 2020 at 17:45)</a>:</h4>
<p>right, sorry, I was thinking of tiny ones</p>



<a name="203537185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537185">(Jul 10 2020 at 17:45)</a>:</h4>
<p>I'm not sure "trivial" tests are so useful. We probably don't need to be tracking incr-compilation performance of hello world for example.</p>



<a name="203537218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537218">(Jul 10 2020 at 17:45)</a>:</h4>
<p>eh it tracks <em>something</em></p>



<a name="203537223"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537223" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537223">(Jul 10 2020 at 17:45)</a>:</h4>
<p>So the converse, tests that represent "real world" uses are probably good candidates for having incr tests.</p>



<a name="203537288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537288">(Jul 10 2020 at 17:46)</a>:</h4>
<p>that might be true, incr-patched for stress tests probably doesn't make much sense</p>



<a name="203537299"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537299" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537299">(Jul 10 2020 at 17:46)</a>:</h4>
<p>unless the stress test models something in the wild etc.</p>



<a name="203537302"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537302" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537302">(Jul 10 2020 at 17:46)</a>:</h4>
<p>Yeah, that's more the example I was thinking of</p>



<a name="203537313"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537313" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537313">(Jul 10 2020 at 17:46)</a>:</h4>
<p><span class="user-mention silent" data-user-id="119009">eddyb</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Incr-patched.20tests/near/203537151">said</a>:</p>
<blockquote>
<p>removing tests is a bad idea in practice</p>
</blockquote>
<p>I agree, deprecating tests isn't that good of an idea because you stop tracking something that could be useful in the long run (well I'm getting close to excessive "what if" thinking here, but I think it makes sense)</p>



<a name="203537315"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537315" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537315">(Jul 10 2020 at 17:46)</a>:</h4>
<p>Hello world is so small time-wise it doesn't really matter so we might as well have it.</p>



<a name="203537332"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537332" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537332">(Jul 10 2020 at 17:46)</a>:</h4>
<p><span class="user-mention silent" data-user-id="119009">eddyb</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Incr-patched.20tests/near/203537299">said</a>:</p>
<blockquote>
<p>unless the stress test models something in the wild etc.</p>
</blockquote>
<p>Ah, good point</p>



<a name="203537380"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537380" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537380">(Jul 10 2020 at 17:47)</a>:</h4>
<p><span class="user-mention silent" data-user-id="125250">Wesley Wiser</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Incr-patched.20tests/near/203537223">said</a>:</p>
<blockquote>
<p>So the converse, tests that represent "real world" uses are probably good candidates for having incr tests.</p>
</blockquote>
<p>I see, yeah, that also makes sense</p>



<a name="203537614"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537614" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537614">(Jul 10 2020 at 17:49)</a>:</h4>
<p>So what I'm getting is that it is like a mix of things in the end. On one hand, one could probably use more incr-patched tests here and there, but OTOH, if they aren't for a test that's more real-world-like, then maybe such a test doesn't make sense.</p>



<a name="203537797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537797">(Jul 10 2020 at 17:51)</a>:</h4>
<p>Thank you all, this helped me understand the topic a bit better :)</p>



<a name="203537810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537810">(Jul 10 2020 at 17:51)</a>:</h4>
<p><span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="203537919"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203537919" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203537919">(Jul 10 2020 at 17:52)</a>:</h4>
<p>Yeah and I think eventually we want more kinds of incr-tests. We should be trying to model some of the user workflows so we're tracking what the users actually see. So for example, "<code>println!()</code> debugging" which we sort of have now but also "fix an off by 1 bug", "add a new function and call it", "write a trait impl for a struct that already exists", etc.</p>



<a name="203538186"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203538186" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203538186">(Jul 10 2020 at 17:55)</a>:</h4>
<p><span class="user-mention silent" data-user-id="125250">Wesley Wiser</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Incr-patched.20tests/near/203537919">said</a>:</p>
<blockquote>
<p>Yeah and I think eventually we want more kinds of incr-tests. We should be trying to model some of the user workflows so we're tracking what the users actually see. So for example, "<code>println!()</code> debugging" which we sort of have now but also "fix an off by 1 bug", "add a new function and call it", "write a trait impl for a struct that already exists", etc.</p>
</blockquote>
<p>This reminds me a bit of mutation testing, in the sense that the mutation engine adds little bits of code that change the behavior of the program a little bit, and checks if the test suite captures that mutant</p>



<a name="203538203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203538203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203538203">(Jul 10 2020 at 17:55)</a>:</h4>
<p>this is a bit like that</p>



<a name="203538228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203538228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203538228">(Jul 10 2020 at 17:55)</a>:</h4>
<p>in the sense that we want to see how much of the incr-comp behaves well under certain small changes</p>



<a name="203538260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203538260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203538260">(Jul 10 2020 at 17:55)</a>:</h4>
<p>yo, this is cool</p>



<a name="203538458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203538458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Félix Fischer <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203538458">(Jul 10 2020 at 17:57)</a>:</h4>
<p>Slight tangent: if all goes well, I should be starting my thesis soon, and it would be on mir-opts. For measuring the success or lack of it, of what I do, I will be using perf.rlo intensively. I hope I can have a lot of feedback on the test suite so that after I'm done with the opt work, I can help make perf.rlo better :)</p>



<a name="203664568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Incr-patched%20tests/near/203664568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Incr-patched.20tests.html#203664568">(Jul 12 2020 at 22:40)</a>:</h4>
<p>The benchmarks are categorized <a href="https://github.com/rust-lang/rustc-perf/blob/master/collector/benchmarks/README.md">here</a>. It  might make sense for all of the "Real world benchmarks that are important" to have <code>incr</code> patch files, and none of the others.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>